Skip to content

test: migrate stats/base/dists/discrete-uniform/median to ULP-based assertions - #14339

Merged
kgryte merged 1 commit into
developfrom
kgryte/ulp-discrete-uniform-median
Aug 17, 2026
Merged

test: migrate stats/base/dists/discrete-uniform/median to ULP-based assertions#14339
kgryte merged 1 commit into
developfrom
kgryte/ulp-discrete-uniform-median

Conversation

@kgryte

@kgryte kgryte commented Aug 17, 2026

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates the tests for stats/base/dists/discrete-uniform/median from relative tolerance assertions to ULP-based assertions.

Specifically, in test/test.js and test/test.native.js, the if ( y === expected[i] ) { ... } else { delta/tol ... } branch is replaced by

t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' );

along with the corresponding require of @stdlib/assert/is-almost-same-value and the removal of the now unused @stdlib/math/base/special/abs and @stdlib/constants/float64/eps requires.

ULP bound: 0 in both test/test.js and test/test.native.js.

The bound was determined empirically by computing, for every entry in the Julia fixture set (1000 cases), the minimum ULP difference required for the assertion to hold. The maximum required over the full fixture set is 0, i.e., every returned value is bit-identical to the expected value, so 0 is the minimum admissible bound. The test suite was run twice at the final bound to confirm determinism (1008 assertions passing on each run).

This result is consistent with the implementations: the JS implementation returns ( a/2 ) + ( b/2 ) and the C implementation returns ( a + b ) / 2.0, both of which are exact for integer-valued a and b in the tested range, and both of which agree bit-for-bit with the fixture values. Note that the native tests are skipped when the native add-on has not been built, so the native bound was additionally checked by evaluating the C expression over the same fixture set.

Only the two test files are modified; no source, fixture, or documentation files are touched.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The conversion mirrors the idiom used in the previously merged sibling package stats/base/dists/discrete-uniform/stdev (#14337).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code running as an unattended scheduled task: it selected the package, studied previously merged ULP migrations for the idiom, applied the test changes, and determined the minimum ULP bound empirically over the fixture set.


@stdlib-js/reviewers


Generated by Claude Code

… assertions

Ref: #11352

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019hrk86NWAm29g4zkctUY4b

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Aug 17, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/discrete-uniform/median $\\color{green}178/178$
$\\color{green}+100.00\\%$
$\\color{green}9/9$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}178/178$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Aug 17, 2026
@kgryte
kgryte marked this pull request as ready for review August 17, 2026 05:49
@kgryte
kgryte requested a review from a team August 17, 2026 05:49
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 17, 2026
@kgryte
kgryte merged commit 1dec81c into develop Aug 17, 2026
82 checks passed
@kgryte
kgryte deleted the kgryte/ulp-discrete-uniform-median branch August 17, 2026 05:49
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants